Timm Bäder [Tue, 29 Jan 2019 13:36:43 +0000 (13:36 +0000)]
Merge branch 'wip/carlosg/texthandles-position' into 'master'
gtkentry: Fix text handle coordinates calculation
See merge request GNOME/gtk!542
Carlos Garnacho [Tue, 29 Jan 2019 11:00:07 +0000 (12:00 +0100)]
gtkentry: Fix text handle coordinates calculation
The text allocation is already in widget-local coordinates, involving the
GtkAllocation here is not right.
Jakub Steiner [Tue, 29 Jan 2019 09:46:34 +0000 (09:46 +0000)]
Merge branch 'expander-row-padding' into 'master'
adwaita: Fix the greediness of row:not(.expander)
See merge request GNOME/gtk!526
Jakub Steiner [Tue, 29 Jan 2019 09:39:57 +0000 (09:39 +0000)]
Merge branch 'adwaita-osd-spinbutton-entry-fix-master' into 'master'
Horizontal OSD spinbutton entry fix
See merge request GNOME/gtk!332
Timm Bäder [Tue, 29 Jan 2019 08:33:40 +0000 (08:33 +0000)]
Merge branch 'wip/matthiasc/event-signal' into 'master'
Remove vestigial ::event support
See merge request GNOME/gtk!538
Timm Bäder [Tue, 29 Jan 2019 06:19:20 +0000 (07:19 +0100)]
widget: Also propagate ACTIVE state when unsetting
Timm Bäder [Tue, 29 Jan 2019 04:29:57 +0000 (05:29 +0100)]
gtkmain: Remove comment mentioning GDK_PROPERTY_NOTIFY
... which doesn't exist anymore.
Timm Bäder [Sun, 27 Jan 2019 05:29:45 +0000 (06:29 +0100)]
widget: Ignore events on unmapped widgets
There was a special case for GtkSearchBar, so remove that one.
Benjamin Otte [Thu, 4 Oct 2018 11:08:14 +0000 (13:08 +0200)]
main: Report correct target for button release events
Button release events should not go to the widget below the pointer, but
to the widget that received the original button press.
Fixes #24
Timm Bäder [Fri, 25 Jan 2019 16:17:20 +0000 (17:17 +0100)]
Remove :active state handling on widgets
Timm Bäder [Fri, 25 Jan 2019 04:39:04 +0000 (05:39 +0100)]
Automatically set :active state on button press/release
Timm Bäder [Tue, 29 Jan 2019 06:17:46 +0000 (07:17 +0100)]
widget: Propagate PRELIGHT state when unsetting it
Without this, disabling a widget that's being hovered and is a child
widget of the widget we're disabling (e.g. the GtkImage child of a
GtkButton) will retain its :hover state even though it should be
insensitive to any sort of input now.
Timm Bäder [Sat, 19 Jan 2019 12:36:42 +0000 (13:36 +0100)]
widget: Avoid some type checks when picking
Timm Bäder [Mon, 21 Jan 2019 16:00:29 +0000 (17:00 +0100)]
csstransformvalue: Convert skew values to radians
Timm Bäder [Sun, 20 Jan 2019 08:22:55 +0000 (09:22 +0100)]
label: Use pango_layout_get_log_attrs_readonly
No need to memdup the log attrs in this case.
Timm Bäder [Sat, 19 Jan 2019 17:32:00 +0000 (18:32 +0100)]
cssparser: Make _gtk_css_parser_try a macro
We almost always pass a constant string to it, so use a macro and try to
trick the compiler into evaluating the 2(!) strlen() calls at compile
time.
Timm Bäder [Sat, 19 Jan 2019 17:05:13 +0000 (18:05 +0100)]
cssanimatedstyle: Avoid some type checks and unnecessary work
Timm Bäder [Sat, 19 Jan 2019 16:53:05 +0000 (17:53 +0100)]
scrolledwindow: Don't NULL the indicator widget in unmap
We still have the widget, so just keep the pointer to it.
Fran Dieguez [Mon, 28 Jan 2019 21:55:11 +0000 (21:55 +0000)]
Update Galician translation
Fran Dieguez [Sun, 27 Jan 2019 21:40:17 +0000 (21:40 +0000)]
Update Galician translation
Balázs Úr [Sun, 27 Jan 2019 20:14:31 +0000 (20:14 +0000)]
Update Hungarian translation
Fran Dieguez [Sun, 27 Jan 2019 00:09:39 +0000 (00:09 +0000)]
Update Galician translation
Fran Dieguez [Sat, 26 Jan 2019 23:53:47 +0000 (23:53 +0000)]
Update Galician translation
Matthias Clasen [Sat, 26 Jan 2019 20:36:55 +0000 (15:36 -0500)]
Remove vestigial ::event support
The signal is gone, no need to keep the vfunc around.
Matthias Clasen [Fri, 25 Jan 2019 17:32:41 +0000 (17:32 +0000)]
Merge branch 'tabular-menus' into 'master'
Drop tabular menus
See merge request GNOME/gtk!527
Matthias Clasen [Fri, 25 Jan 2019 02:30:08 +0000 (02:30 +0000)]
Merge branch 'switch-icons' into 'master'
Use switch icons
See merge request GNOME/gtk!529
Matthias Clasen [Fri, 25 Jan 2019 02:10:12 +0000 (21:10 -0500)]
Update css tests results
These now show images as children of the switch,
as expected.
Matthias Clasen [Thu, 24 Jan 2019 21:15:43 +0000 (16:15 -0500)]
icon browser: Add on and off icons
These are going to be used internally.
Matthias Clasen [Thu, 24 Jan 2019 21:11:45 +0000 (16:11 -0500)]
Fix gtk4-icon-browser
It was broken by a recent GtkDialog change that renamed
the internal vbox child to content_area.
Matthias Clasen [Thu, 24 Jan 2019 21:12:47 +0000 (16:12 -0500)]
switch: Use icons
This works better than glyphs, avoiding the
uncertainties of font availability and fallback..
Matthias Clasen [Thu, 24 Jan 2019 21:12:27 +0000 (16:12 -0500)]
Add switch icons
These will be used in GtkSwitch in the future.
Matthias Clasen [Thu, 24 Jan 2019 04:36:04 +0000 (23:36 -0500)]
menu: Drop the child properties
These were only there in support of tabular menus.
Matthias Clasen [Thu, 24 Jan 2019 04:30:18 +0000 (23:30 -0500)]
Drop gtk_menu_attach
We no longer support tabular menus.
Matthias Clasen [Thu, 24 Jan 2019 04:20:22 +0000 (23:20 -0500)]
tree menu: Drop support for grids
This was only used in GtkComboBox, and it no longer
supports grids,
Matthias Clasen [Thu, 24 Jan 2019 03:52:36 +0000 (22:52 -0500)]
combobox: Drop support for grids
This is pretty much unued, and we want to get rid of it.
This removes support for wrap-width, row-span-column
and column-span-column properties.
Matthias Clasen [Thu, 24 Jan 2019 03:52:16 +0000 (22:52 -0500)]
testcombo fixup
Matthias Clasen [Thu, 24 Jan 2019 03:51:48 +0000 (22:51 -0500)]
fixup notify tests
Matthias Clasen [Thu, 24 Jan 2019 03:45:55 +0000 (22:45 -0500)]
Drop a grid combo example
Matthias Clasen [Thu, 24 Jan 2019 03:42:51 +0000 (22:42 -0500)]
Drop row/column-span-column from tests
Matthias Clasen [Thu, 24 Jan 2019 03:40:53 +0000 (22:40 -0500)]
testgtk: Drop tabular menu
Tabular menus are basically unused, and we want to drop this.
Matthias Clasen [Thu, 24 Jan 2019 03:33:44 +0000 (22:33 -0500)]
gl texture: fix a typo
Matthias Clasen [Thu, 24 Jan 2019 01:05:28 +0000 (20:05 -0500)]
header bar: Drop the position child property
There is no particular need to have this, and we want
to get rid of child properties.
Matthias Clasen [Wed, 23 Jan 2019 01:10:06 +0000 (20:10 -0500)]
action bar: Drop the position child property
There is no particular need to have this, and we want
to get rid of child properties.
Matthias Clasen [Tue, 22 Jan 2019 23:44:34 +0000 (18:44 -0500)]
box: Avoid position in the reorder api
Change the reorder api to insert after a sibling,
so that moving to first place becomes reorder (... NULL).
And add a insert_after api that can replace the common
container_add / reorder_after (... NULL) combination.
Update all callers.
Matthias Clasen [Tue, 22 Jan 2019 23:31:01 +0000 (18:31 -0500)]
box: Remove the position child property
The position child property is problematic, since it
requires us to emit notification for all children when
inserting a child early in the list of children.
Remove the property from all ui files.
Timm Bäder [Sat, 29 Dec 2018 08:53:16 +0000 (09:53 +0100)]
migration guide: Add a paragraph about GtkBox's pack-type
Timm Bäder [Sat, 29 Dec 2018 08:49:24 +0000 (09:49 +0100)]
box: Remove gtk_box_pack_start
Timm Bäder [Sat, 29 Dec 2018 08:43:15 +0000 (09:43 +0100)]
box: Remove gtk_box_pack_end
Timm Bäder [Fri, 28 Dec 2018 16:51:39 +0000 (17:51 +0100)]
box: Simplify documentation
Remove all references to any sort of "packing".
Timm Bäder [Fri, 28 Dec 2018 16:17:16 +0000 (17:17 +0100)]
box: Remove children list
GtkWidget saves a widget list for us, so we don't need to keep track of
them ourselves. This is okay now that we don't have a pack-type child
property anymore.
Timm Bäder [Fri, 28 Dec 2018 15:53:17 +0000 (16:53 +0100)]
testsuite: Remove box packing css node tests
Testing the correct css order for mixed pack-start/pack-end cases
doesn't make sense if boxes don't have a notion of pack-type anymore.
Timm Bäder [Wed, 26 Dec 2018 08:49:10 +0000 (09:49 +0100)]
box: Remove pack-type child property
Timm Bäder [Wed, 26 Dec 2018 08:23:45 +0000 (09:23 +0100)]
assistant: Fix button order in ui file
Timm Bäder [Wed, 26 Dec 2018 08:00:08 +0000 (09:00 +0100)]
dialog: Expose the content area as a separate GtkBox child
This way, the "vbox" internal child does not contain anything by
default. It previously did contain "internal" widgetry like the action
area.
Timm Bäder [Wed, 26 Dec 2018 07:55:46 +0000 (08:55 +0100)]
Stop using GtkBox's pack-type child prop in UI files
Timm Bäder [Wed, 26 Dec 2018 07:34:47 +0000 (08:34 +0100)]
combobox: Stop using GtkBox's pack-type property
Reorder the child widgets accordingly instead.
Timm Bäder [Wed, 26 Dec 2018 07:26:41 +0000 (08:26 +0100)]
scalebutton: Stop relying on GtkBox's pack-type child prop
Timm Bäder [Wed, 26 Dec 2018 07:20:34 +0000 (08:20 +0100)]
Stop using gtk_box_pack_end
It might soon go away!
Timm Bäder [Wed, 26 Dec 2018 06:45:31 +0000 (07:45 +0100)]
tests: Remove flicker test
gtk+ hasn't been flickering in ages so this test isn't very useful.
Timm Bäder [Wed, 26 Dec 2018 06:08:16 +0000 (07:08 +0100)]
shortcutssection: Use a center box as footer
Matthias Clasen [Thu, 24 Jan 2019 00:27:35 +0000 (19:27 -0500)]
Update a11y tests
Working towards a passing testsuite.
Matthias Clasen [Wed, 23 Jan 2019 17:02:27 +0000 (12:02 -0500)]
switch: Avoid problems with glyph availability
If none of the glyphs we want are available, fall
back to using empty strings here, rather than causing
critical warnings.
Adrien Plazas [Wed, 23 Jan 2019 20:27:33 +0000 (21:27 +0100)]
adwaita: Fix the greediness of row:not(.expander)
This avoids list rows (e.g. the ones in a stack sidebar) to be
accidentally selected and see their padding messed up.
Jakub Steiner [Tue, 22 Jan 2019 12:57:07 +0000 (12:57 +0000)]
Merge branch 'expander-row-padding' into 'master'
adwaita: Fix the padding of row.expander
See merge request GNOME/gtk!521
Adrien Plazas [Tue, 22 Jan 2019 11:43:07 +0000 (12:43 +0100)]
adwaita: Fix the padding of row.expander
This will allow to implement the expanding rows pattern.
Benjamin Otte [Tue, 22 Jan 2019 03:30:47 +0000 (04:30 +0100)]
build: Reintroduce warning flags from autotools
Some of the flags got lost in the meson transition or were demoted from
error flags to warning flags.
This commit reintroduces them.
It also includes fixes for the code that had warnings with those flags.
The big one being -Wshadow.
Benjamin Otte [Sun, 20 Jan 2019 15:09:36 +0000 (16:09 +0100)]
meson.build: Order warning flags alphabetically
... and remove the duplicate we already had.
Benjamin Otte [Tue, 22 Jan 2019 03:28:14 +0000 (04:28 +0100)]
imcontextwayland: Get rid of global variable
Attach it to the GdkDisplay.
Also fixes -Wshadow complaining about "global" being shadowed.
Benjamin Otte [Sun, 20 Jan 2019 23:48:48 +0000 (00:48 +0100)]
immodule: Clean up loading code
Remove the unneeded is_platform() check and just go by extension point
priority.
Also g_error() out if no im module exists, because "simple" is compiled
in and should always exist.
Benjamin Otte [Sun, 20 Jan 2019 23:47:30 +0000 (00:47 +0100)]
imcontext: Fix priorities of modules
All built-in backend modules get a priority of 0 because they are the
default ones.
GtkIMContextSimple gets a priority of G_MININT because it's the fallback
one.
This mirrors the media modules code.
Timm Bäder [Mon, 21 Jan 2019 07:05:26 +0000 (07:05 +0000)]
Merge branch 'no-more-bgo' into 'master'
docs: Point people at the right place for bugs
Closes #1559
See merge request GNOME/gtk!498
Chun-wei Fan [Mon, 21 Jan 2019 05:49:20 +0000 (13:49 +0800)]
testsuite/gtk/slicelistmodel.c: Avoid VLAs
Unfortunately VLA's are unlikely to be supported on any Visual Studio
versions, although it is C99, so replace it with g_newa() calls.
Pieter Schalk Schoeman [Sun, 20 Jan 2019 23:28:41 +0000 (23:28 +0000)]
Update Afrikaans translation
Pieter Schalk Schoeman [Sun, 20 Jan 2019 23:26:52 +0000 (23:26 +0000)]
Update Afrikaans translation
Matthias Clasen [Sun, 6 Jan 2019 17:25:50 +0000 (12:25 -0500)]
testsuite: Add slice model tests
Do the same style of tests we do for all the
other list models. These tests found the issue
fixed in the previous commit.
Matthias Clasen [Sun, 6 Jan 2019 17:24:57 +0000 (12:24 -0500)]
slice model: Don't report excessive changes
We were not skipping an unchanged initial segment
of the slice in some cases. Fix that.
Benjamin Otte [Sun, 20 Jan 2019 05:07:52 +0000 (06:07 +0100)]
rbtree: Fix a crash in insertion fixup
This got broken in commit
a33ff4c6ab3a196b3c71da48e4e650da85d1691c.
Testcase included.
Benjamin Otte [Sun, 20 Jan 2019 05:06:18 +0000 (06:06 +0100)]
rbtree: Add a trivial way to add rbtree tests to the testsuite.
The format of the printout will be suitable for addition as a new test to
testsuite/gtk/rbtree-crash.c
by just grepping the printouts from the relevant rbtree.
Matthias Clasen [Sat, 19 Jan 2019 01:13:42 +0000 (01:13 +0000)]
Merge branch 'reference-include' into 'master'
Specify the C include for Unix printing API
See merge request GNOME/gtk!516
Michael Catanzaro [Wed, 16 Jan 2019 01:51:00 +0000 (19:51 -0600)]
filechoosernativeportal: stuff the current filter into options
We need to tell the portal what filter is supposed to be selected by
default, or it will just pick the first one, which could be wrong and
annoying.
This will require updated xdg-desktop-portal and xdg-desktop-portal-gtk
to work properly.
Fixes #1492
Michael Catanzaro [Tue, 15 Jan 2019 02:53:19 +0000 (20:53 -0600)]
filechoosernativeportal: remove redundant casts
We are casting from GtkFileChooserNative to... GtkFileChooserNative.
Boo.
Michael Catanzaro [Thu, 29 Nov 2018 21:34:17 +0000 (15:34 -0600)]
filechoosernative: forward current_filter to delegate dialog
gtk_file_chooser_set_filter() doesn't work for GtkFileChooserNative. The
code forwards added and removed filters to the delegate dialog, but
doesn't do anything to set the selected one, so the wrong one gets
chosen. So fix that.
This only fixes the fallback dialog. The portal will be fixed in a
subsequent commit.
Partial fix for #1492
Emmanuele Bassi [Sat, 19 Jan 2019 00:00:34 +0000 (00:00 +0000)]
Specify the C include for Unix printing API
Instead of using the INCLUDE directive inside the sections file, we can
specify the default C include in the gtkdoc-mkdb arguments, and override
it inside the C sources that need it.
Emmanuele Bassi [Fri, 18 Jan 2019 23:13:31 +0000 (23:13 +0000)]
Merge branch 'master' into 'master'
A11y: export gtk_cell_accessible_parent_get_(row|column)_header_cells
See merge request GNOME/gtk!505
Matthias Clasen [Fri, 18 Jan 2019 22:43:54 +0000 (22:43 +0000)]
Merge branch 'switch-fallback' into 'master'
Add fallback glyphs for GtkSwitch states
See merge request GNOME/gtk!509
Matthias Clasen [Wed, 16 Jan 2019 04:16:16 +0000 (23:16 -0500)]
about dialog: Use ::activate-link for license
This should behave the same as all the other links
in this dialog.
Closes: #1561
Timm Bäder [Fri, 18 Jan 2019 12:06:41 +0000 (13:06 +0100)]
gl renderer: Support (not) resetting the opacity for offscreen nodes
We usually want to do that, but it's wrong for e.g. crossfade nodes.
Timm Bäder [Fri, 18 Jan 2019 10:29:44 +0000 (11:29 +0100)]
entry: Use pango_layout_get_log_attrs_readonly
Since we're not modifying anything...
Timm Bäder [Fri, 18 Jan 2019 09:47:16 +0000 (10:47 +0100)]
entry: Use a label as placeholder
This gives us a better way of choosing the color of the placeholder text
(and enabled general css styling on it of course).
Closes #378 (If you want to keep the placeholder on focused and empty
entries, just don't set the placeholder opacity to 0 in
entry:focus>placeholder. This is the default behavior but this commit
includes a rule in Adwaita to hide it.
Timm Bäder [Fri, 18 Jan 2019 09:41:59 +0000 (10:41 +0100)]
entry: Trivial indentation fix
Timm Bäder [Fri, 18 Jan 2019 08:28:03 +0000 (09:28 +0100)]
tooltip: Use gdk_rectangle_contains_point
Timm Bäder [Fri, 18 Jan 2019 08:16:44 +0000 (09:16 +0100)]
tooltip: Move tooltips enabled checks into tooltips_enabled
Timm Bäder [Fri, 18 Jan 2019 07:48:07 +0000 (08:48 +0100)]
tooltip: Look at the event's target widget
Since we now have a widget whenever we query tooltips, we can as well
get the events target_widget if we have an event (which is what we do
when coming from gtkmain.c). This keeps us from searching the entire
widget hierarchy for the target event even though we've already done
that for pointing events in gtkmain.c
This reduced the work done in gtk_tooltip_handle_event in normal motion
events to basically nothing since we already did all the heavy lifting
when handling the pointing event in gtkmain.c
Timm Bäder [Fri, 18 Jan 2019 07:34:59 +0000 (08:34 +0100)]
tooltip: Remove gtk_tooltip_trigger_tooltip_query
As stated by the documentation, this should be called when a widget gets
updated, but in that case, one can equally use
gtk_widget_trigger_tooltip_query.
Timm Bäder [Fri, 18 Jan 2019 07:27:28 +0000 (08:27 +0100)]
tooltips: Remove keyboard mode tooltips
Keyboard mode was only used in gtk_widget_real_show_help before, but now
that's gone and so is any usage of keyboard mode tooltips.
Timm Bäder [Fri, 18 Jan 2019 07:01:40 +0000 (08:01 +0100)]
gizmo: return void from snapshot func
This boolean return was from the old gadget code and we weren't using it
in the new gizmo code.
Timm Bäder [Wed, 16 Jan 2019 13:24:59 +0000 (14:24 +0100)]
scrolledwindow: Reset indicators in unmap()
This is unrelated to any windowing resources these days, so no need for
an unrealize handler.
Timm Bäder [Thu, 17 Jan 2019 16:08:58 +0000 (17:08 +0100)]
filechooserwidget: Show spinner when searching
This was lost it seems
Timm Bäder [Thu, 17 Jan 2019 16:02:49 +0000 (17:02 +0100)]
GdkEvent: Make gdk_event_set_user_data private
Timm Bäder [Thu, 17 Jan 2019 15:29:40 +0000 (16:29 +0100)]
GdkEvent: Remove unused struct